-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
python310Packages.matplotlib: multiple cleanup commits #279317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM
d31334c
to
2173e1c
Compare
Changed the target to staging. |
Hmm CI is not green... I'm fairly sure that if CI was green on master, this commit shouldn't cause a real eval issue on |
@GrahamcOfBorg eval |
Still, same errors. |
The link to the build docs is outdated, and it doesn't have an updated direct alternative. While I tried to enable at least some of the tests, I encountered NixOS#255262 which is now linked in a comment.
2173e1c
to
eba8931
Compare
Result of 2 packages built:
|
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.